Skip to content

Commit f46b422

Browse files
authored
Merge pull request #8 from desultory/dev
clean up cached exporter
2 parents 702433d + a4c6e9b commit f46b422

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/prometheus_exporter/cached_exporter.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,9 @@ def cache_age(self) -> int:
5858
self.logger.debug("[%s] Cache age: %d" % (self.name, cache_age))
5959
return time() - getattr(self, "_cache_time", 0)
6060

61-
async def get_metrics(self, label_filter={}) -> list:
61+
async def get_metrics(self, label_filter=None) -> list:
6262
"""Get metrics from the exporter, respecting label filters and caching the result."""
63-
for key, value in label_filter.items():
64-
if key not in self.labels and self.labels[key] != value:
65-
self.logger.debug("Label filter check failed: %s != %s", self.labels, label_filter)
66-
return []
63+
label_filter = label_filter or {}
6764

6865
if not hasattr(self, "_cached_metrics") or self.cache_age >= self.cache_life:
6966
if new_metrics := await super().get_metrics(label_filter=label_filter):

0 commit comments

Comments
 (0)