Skip to content

ensure editing lables within metrics doesn't affect global labels #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

ensure editing lables within metrics doesn't affect global labels #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/test_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,18 @@ def test_global_labels_override(self):
for metric in random_metrics:
self.assertIn(f'{metric}{{global_label="global_value"}} 0', export)

def test_edited_metric_labels(self):
"""Test that editing labels on an added metric do not affect global labels"""
test_labels = {"label1": "value1", "label2": "value2"}
e = Exporter(no_config_file=True, labels=test_labels)
random_metrics = generate_random_metric_config(10)
e.config["metrics"] = random_metrics
e.metrics = []
e.export_config_metrics() # Generate metrics from the config
for metric in e.metrics:
self.assertEqual(metric.labels, test_labels)
metric.labels = {"asdf": str(uuid4())}
self.assertEqual(e.labels, test_labels)

def test_append_metrics(self):
"""Ensures metrics can be appended after init"""
Expand Down
Loading