Skip to content

clean up cached exporter #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

clean up cached exporter #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ab560
don't set dict in cached exporter get_metrics kwargs
desultory May 14, 2025
a4c6e9b
don't do needless filtering in the cached_exporter get_metrics
desultory May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/prometheus_exporter/cached_exporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,12 +58,9 @@ def cache_age(self) -> int:
self.logger.debug("[%s] Cache age: %d" % (self.name, cache_age))
return time() - getattr(self, "_cache_time", 0)

async def get_metrics(self, label_filter={}) -> list:
async def get_metrics(self, label_filter=None) -> list:
"""Get metrics from the exporter, respecting label filters and caching the result."""
for key, value in label_filter.items():
if key not in self.labels and self.labels[key] != value:
self.logger.debug("Label filter check failed: %s != %s", self.labels, label_filter)
return []
label_filter = label_filter or {}

if not hasattr(self, "_cached_metrics") or self.cache_age >= self.cache_life:
if new_metrics := await super().get_metrics(label_filter=label_filter):
Expand Down