Support zstd compression #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hardcoded compression level 10. On my system it compresses the initramfs I generated under a second. Numbers from my testing: * ugrd.cpio is 20MB * ugrd.cpio.xz is 6.2MB * Compression takes 14s * Decompression takes 0.5s * ugrd.cpio.zst is 7.5MB * Compress takes 0.88s * Decompression takes 0.08s
Owner
|
Thank you! I think I will add some tests for this. One thing I've been considering is how the compression level should be specified. I tried to make the compression option somewhat open ended (despite being somewhat hardcoded for xz) and wasn't sure how to generalize compression levels for various algorithms. |
Owner
|
I added a compression level setting here, and tried to generalize the imports a bit more, with improved error messages on failed imports. |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hardcoded compression level 10. On my system it compresses the initramfs I generated under a second.
Numbers from my testing: