Skip to content

Commit

Permalink
unwanted code removed
Browse files Browse the repository at this point in the history
  • Loading branch information
prathameshzarkar9 committed Oct 18, 2024
1 parent 1f12fe8 commit 0805d6f
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/spec-common/injectHeadless.ts
Original file line number Diff line number Diff line change
Expand Up @@ -540,12 +540,6 @@ async function runLifecycleCommand({ lifecycleHook }: ResolverParameters, contai
}

await Promise.all(commands);

infoOutput.event({
type: 'progress',
name: progressName,
status: 'succeeded',
});
} catch {
infoOutput.event({
type: 'progress',
Expand Down
7 changes: 7 additions & 0 deletions src/test/cli.up.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ describe('Dev Containers CLI', function () {
});

describe('Command up', () => {
it('should succeed (dockerfile) with supported --error for poetry', async () => {
const testFolder = `${__dirname}/configs/poetry-example`;
const res = await shellExec(`${cli} up --workspace-folder ${testFolder}`);
const response = JSON.parse(res.stdout);
assert.equal(response.outcome, 'success');
});

it('should execute successfully with valid config', async () => {
const res = await shellExec(`${cli} up --workspace-folder ${__dirname}/configs/image --include-configuration --include-merged-configuration`);
const response = JSON.parse(res.stdout);
Expand Down
18 changes: 18 additions & 0 deletions src/test/configs/poetry-example/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
// Example devcontainer.json configuration,
// wired into the vscode launch task (.vscode/launch.json)
{
"image": "mcr.microsoft.com/devcontainers/base:latest",
"features": {
"ghcr.io/devcontainers/features/python:1": {
"version": "latest"
}
},
"postStartCommand": {
"poetry setup": [
"/bin/bash",
"-i",
"-c",
"python3 -m venv $HOME/.local && source $HOME/.local/bin/activate && poetry install"
]
}
}

0 comments on commit 0805d6f

Please sign in to comment.