Skip to content

Commit

Permalink
Do not use build contexts with Podman and Compose (microsoft/vscode-r…
Browse files Browse the repository at this point in the history
  • Loading branch information
chrmarti committed Jan 6, 2025
1 parent e0598db commit a22ba59
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/spec-node/containerFeatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,9 @@ async function getFeaturesBuildOptions(params: DockerResolverParameters, devCont
// TODO generate an image name that is specific to this dev container?
const buildKitVersionParsed = params.buildKitVersion?.versionMatch ? parseVersion(params.buildKitVersion.versionMatch) : undefined;
const minRequiredVersion = [0, 8, 0];
const useBuildKitBuildContexts = buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false;
const useBuildKitBuildContexts = params.isPodman
? !('dockerComposeFile' in devContainerConfig.config) // https://github.com/microsoft/vscode-remote-release/issues/10178#issuecomment-2330257443
: buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false;
const buildContentImageName = 'dev_container_feature_content_temp';
const isBuildah = !!params.buildKitVersion?.versionString.toLowerCase().includes('buildah');

Expand Down

0 comments on commit a22ba59

Please sign in to comment.