issue missing root cause of error #845 solution #933
Conversation
|
@gauravsaini04 It looks like you started from a different change than the very latest in #852. Please make sure to pull in the latest from there and address my latest comment on top. Thanks! |
| if (name) { | ||
| infoOutput.raw(`\x1b[1mRunning ${name} of ${lifecycleHookName} from ${userCommandOrigin}...\x1b[0m\r\n${cmdOutput}\r\n`); | ||
| } | ||
| } catch (err) { |
There was a problem hiding this comment.
so basically what i understood is that you'd like me to push this code of catching the error inside runSingleCommand method to be after https://github.com/devcontainers/cli/blob/main/src/spec-common/injectHeadless.ts#L531 i.e. await Promise.all(commands), in the catch block that's written after it
( in your comment here )
There was a problem hiding this comment.
I think we are very close in #852. I suggest we continue there since that has all the history of the discussion. I have pushed the suggested fixes there, please take a look and leave a review. Thanks!
There was a problem hiding this comment.
closing this as #852 was already merged.
Ref: #845
Description
changelog
src/spec-common/injectHeadless.tsfile as well as a launch.json configuration for cli debugging atsrc/test/configs/poetry-example/.devcontainer.jsonchecklist