Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.4 in php and universal images #1275

Merged
merged 6 commits into from
Feb 25, 2025

Conversation

Kaniska244
Copy link
Contributor

Ref: #1252

Devcontainer name

PHP, Universal

Description

This pr adds 8.4 latest php version to the supported versions list in php and universal images

Changelog

  • Changes are there in manifest.json, Dockerfile and readme.md file for php image to add support to latest 8.4 php version.
  • Changes in devcontainer.json file for universal image to support latest 8.4 php version.

Checklist

  • Checked that applied changed work as expected

@Kaniska244 Kaniska244 marked this pull request as ready for review December 31, 2024 08:59
@Kaniska244 Kaniska244 requested a review from a team as a code owner December 31, 2024 09:00
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚢

@eljog
Copy link
Member

eljog commented Feb 3, 2025

@Kaniska244 could you please check failing tests?

@Kaniska244
Copy link
Contributor Author

@Kaniska244 could you please check failing tests?

Hi @eljog ,

This is the same universal test issue we are trying to solve as part of PR #1287

With Regards,
Kaniska

@ddoyle2017 ddoyle2017 merged commit 36200bb into devcontainers:main Feb 25, 2025
3 checks passed
@Kaniska244 Kaniska244 deleted the PHP_8.4_Upgrade branch February 25, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants