Skip to content

Conversation

@gadomski
Copy link
Contributor

@gadomski gadomski commented Dec 1, 2025

⚠️ Checklist if your PR is changing anything else than documentation

Merge request description

A client has reported that AWS was yelling about deprecations on node 20 runtimes, so I figure sticking to latest would be good?

@gadomski gadomski requested a review from hrodmn December 1, 2025 15:07
@gadomski gadomski self-assigned this Dec 1, 2025
@gadomski
Copy link
Contributor Author

gadomski commented Dec 1, 2025

@hrodmn re-requesting approval, tests failed b/c of the 403 to 401 change in https://github.com/fastapi/fastapi/releases/tag/0.122.0. I've only raised the fastapi version in the dev dependencies of the ingestor, since presumably the older versions still work, they just break our tests.

@gadomski gadomski requested a review from hrodmn December 1, 2025 15:33
@hrodmn
Copy link
Contributor

hrodmn commented Dec 1, 2025

@hrodmn re-requesting approval, tests failed b/c of the 403 to 401 change in https://github.com/fastapi/fastapi/releases/tag/0.122.0. I've only raised the fastapi version in the dev dependencies of the ingestor, since presumably the older versions still work, they just break our tests.

Thanks @gadomski - I followed a follow-up to use uv to manage the ingestor-api so we can do a better job avoiding future dependency grenades #215

@gadomski gadomski merged commit c1ece35 into main Dec 1, 2025
5 checks passed
@gadomski gadomski deleted the update-node-runtime branch December 1, 2025 16:12
@ds-release-bot
Copy link
Contributor

ds-release-bot bot commented Dec 1, 2025

🎉 This PR is included in version 10.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants