-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tipg-api #62
feat: tipg-api #62
Conversation
06280c7
to
acf913d
Compare
@vincentsarago is the only TODO left to add a readme ? It looks like the rest is done to me, but I'm not 100% sure because I haven't worked with tipg yet. |
@emileten yes, I'll try to pickup this PR tomorrow but if you want to have a look and check that I haven't done anything stupid feel free 🙏 |
@vincentsarago I integrated this to our maap-eoapi stack, and it deployed successfully, however a get request to the resulting
|
it's the same problem that was caused by #61 but there it was with the tiler. Here, the problem was : we do
Back when I added the titiler pgstac construct here I decided to reuse the standard app layer from the titiler package (titiler.main.app) nbecause I saw no reason to duplicate code. Anyways, just like for the tiler bug, I chose (1) to solve this bug. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vincentsarago I think it's now good to go (see above), feel free to merge. A couple things to note.
- Could you point me to an example running tipg api ? I am not familiar with the technology and I would like to have a look. Is the eoapi dev a good place to look at ?
- Do you have examples of inserting data into the pgstac database that tipg can read ? I tried deploying this connected to the MAAP pgstac database but we only have STAC records there, so nothing that tipg could read, if I understand well.
- We should add an option for a tipg custom domain name later, just like we did here for the stac-api, the stac-ingestor, and titiler-pgstac.
Not really, tipg is not meant to render data from pgstac but maybe ingested in other schemas. We can render
I think we should do it in the PR as well 🙏 Thank @emileten for this nice review and fixes 🙌 |
Oh yes let's do it here.
Ok maybe I need to rephrase my question @vincentsarago and it also shows the limit of my knowledge about databases. So we're connecting |
Yeah, by default tipg will connect to the
Not really, you can do |
# [5.2.0](v5.1.0...v5.2.0) (2023-08-30) ### Features * tipg-api ([#62](#62)) ([24faa85](24faa85))
closes #51
Todo