-
Notifications
You must be signed in to change notification settings - Fork 0
fix: apply fixes after doing all UKCP18 runs #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ca9fa2c
to
f557633
Compare
f557633
to
32eb020
Compare
On first attempt to run the workflow as recommended above, I get
and later
This is the image version:
|
Btw, unrelated to this PR - I also set store: "./indicator/uk_60km_data" in the inputs yaml file, but got the indicator results stored in I think this might be an issue to look into, because output dirs really need to be predictable. 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that
- ✅ the
--tmpdir-prefix
option affects where the UKCP data is cached and - ✅ the indicator output files get produced as expected. 👌
- ✅ read and plotted
_map
and_xarray
with xarray - see notebook
32eb020
to
c4ab7b0
Compare
121824d
to
0fc6a6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had another look, this time reviewing the changes to the STAC item metadata that gets produced.
- ✅ new indicator STAC metadata includes product-specific paths, rather than templates, and shortened descriptions (nice way to diff, from @ciaransweet: https://www.diffchecker.com/yitCSG42/)
What this PR is
This PR applies several fixes after I ran the UKCP18 Indicator generation for all the inputs we require
Changes:
threshold_list
andthreshold_temperature
so we can change them per run configdask_cluster_kwargs
so that we can make processing sequential (as needed for memory restricted environments)src/hazard/sources/ukcp18.py
'sfsspec.filesystem
to be afilecache
ftp
implementation. This will store downloaded files under/tmp/ukcp18cache/
so we don't have to download GB files every year of calculationscollection
as a parameter to pass to theUKCP18
dataset, this can be derived from the desired resolutionglobal
60km
dataHow you can test it
A 'nice' small dataset to test is the UK 60km Days Tas Above, here's an example input file:
You should get:
uk_60km_dta_tree.txt
💡Useful note 💡
You can pass
cwltool
where you want/tmp
in the container to be mounted to, I found this useful for keeping tabs on/tmp
usage: