-
Notifications
You must be signed in to change notification settings - Fork 0
feat: generate hazard descriptions programmatically #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ciaran Sweet <[email protected]>
Signed-off-by: Ciaran Sweet <[email protected]>
Signed-off-by: Ciaran Sweet <[email protected]>
Signed-off-by: Ciaran Sweet <[email protected]>
15d67f8
to
9f407fb
Compare
Signed-off-by: Ciaran Sweet <[email protected]>
Signed-off-by: Ciaran Sweet <[email protected]>
Diff will be slightly out as I had to fix the UKCP18 years, but it's close enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dynamically generating the hazard indicator descriptions based on source and parameters is a great improvement that may make the descriptions even more valuable to downstream applications.
Clean implementation and the generate descriptions read well. 👌
Signed-off-by: Ciaran Sweet <[email protected]>
* Modify workflow into `hazard_workflow.cwl` (#9) Signed-off-by: Ciaran Sweet <[email protected]> * feat: allow to write inventory for (stac, osc, all) and expose xarray output (#10) * feat: allow to write inventory for (stac, osc, all) and expose xarray output * Use latest image Signed-off-by: Ciaran Sweet <[email protected]> * Enable more UKCP18 resolutions and expose dataset kwargs (#11) * feat: support more UKCP18 resolutions * feat: add source_dataset_kwargs to cwl * feat: support eur 12km * feat: fetch crs from .nc file Signed-off-by: Ciaran Sweet <[email protected]> * fix: undo change to default threshold value (#12) Signed-off-by: Ciaran Sweet <[email protected]> * Separate source data information from model information (#13) Signed-off-by: Jonas <[email protected]> * fix: improvements after generating UKCP18 indicators --------- Signed-off-by: Ciaran Sweet <[email protected]> * feat: update hazard cwl input example (#15) Signed-off-by: Ciaran Sweet <[email protected]> * feat: generate hazard descriptions programmatically (#16) Signed-off-by: Ciaran Sweet <[email protected]> --------- Signed-off-by: Ciaran Sweet <[email protected]> Signed-off-by: Jonas <[email protected]> Co-authored-by: Jonas <[email protected]>
What this PR is
days_tas_above.py
anddegree_days.py
to have agenerate_description
functionHow you can test it
You should be able to run the workflow:
Where
input.yml
contains:And you should see a description like:
This was from
chronic_heat_osc_v2_days_tas_above_20c_ukcp18_rcp85_2030.json
for exampleDiff here: https://www.diffchecker.com/l3fUzyxc/ - The degree symbol changes are just because the 'before' was copy and pasted from elsewhere, the degree symbol still renders fine in the 'after'.