-
Notifications
You must be signed in to change notification settings - Fork 16
HNSW Impl #283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
HNSW Impl #283
Conversation
Benchmark Results |
ahnlich/similarity/src/hnsw.rs
Outdated
| #[derive(Debug, Clone)] | ||
| pub struct LayerIndex(pub u16); | ||
|
|
||
| impl PartialEq for LayerIndex { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can derive PartialEq and Eq since it's a simple new type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe PartialOrd too
ahnlich/similarity/src/hnsw.rs
Outdated
| } | ||
|
|
||
| /// NodeId wraps String(hash of node embeddings) to uniquely identify a node across all layers. | ||
| #[derive(Debug, Clone)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implicit trait derives as well
abf6b5f to
1ef1e7e
Compare
1ef1e7e to
9d4b5d0
Compare
Part of #184. Introduces the HNSW implementation with little to no improvements(Correctness over optimization)