Skip to content

Conversation

@deven96
Copy link
Owner

@deven96 deven96 commented Jan 4, 2026

related to #227

  • Introduced the ModelResponse type which splits between models that return one output for one input and models that return multiple output for one input
  • Upgraded Rust to 1.92.0
  • Fixed SingleInputToEmbedding to reflect the fact that embeddings returned can be multiples

@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Test Results

196 tests   196 ✅  9m 1s ⏱️
 31 suites    0 💤
  3 files      0 ❌

Results for commit 0dc3f81.

♻️ This comment has been updated with latest results.

@deven96 deven96 force-pushed the diretnan/multiembedding-support branch 2 times, most recently from 9380a44 to f4622cc Compare January 4, 2026 12:52
@github-actions
Copy link

github-actions bot commented Jan 4, 2026

Benchmark Results

group                                                        main                                   pr
-----                                                        ----                                   --
store_batch_insertion_without_predicates/size_100            1.00   795.0±11.89µs        ? ?/sec    1.01    802.1±2.68µs        ? ?/sec
store_batch_insertion_without_predicates/size_1000           1.00      6.8±0.02ms        ? ?/sec    1.03      7.0±0.04ms        ? ?/sec
store_batch_insertion_without_predicates/size_10000          1.00     83.8±0.21ms        ? ?/sec    1.02     85.3±0.30ms        ? ?/sec
store_batch_insertion_without_predicates/size_100000         1.00    846.0±3.68ms        ? ?/sec    1.02    864.6±3.60ms        ? ?/sec
store_retrieval_no_condition/size_100                        1.02   1706.6±3.19µs        ? ?/sec    1.00   1674.6±4.12µs        ? ?/sec
store_retrieval_no_condition/size_1000                       1.01     11.8±0.02ms        ? ?/sec    1.00     11.7±0.07ms        ? ?/sec
store_retrieval_no_condition/size_10000                      1.02    117.2±0.15ms        ? ?/sec    1.00    115.0±0.23ms        ? ?/sec
store_retrieval_no_condition/size_100000                     1.02   1177.9±0.75ms        ? ?/sec    1.00   1158.1±5.18ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100                   1.02   1802.6±3.83µs        ? ?/sec    1.00   1767.2±4.51µs        ? ?/sec
store_retrieval_non_linear_kdtree/size_1000                  1.00     13.0±0.05ms        ? ?/sec    1.00     13.0±0.07ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_10000                 1.01    129.9±0.16ms        ? ?/sec    1.00    128.7±0.90ms        ? ?/sec
store_retrieval_non_linear_kdtree/size_100000                1.01   1313.4±2.86ms        ? ?/sec    1.00   1298.4±7.58ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100       1.02   1133.7±1.76µs        ? ?/sec    1.00   1111.4±2.89µs        ? ?/sec
store_sequential_insertion_without_predicates/size_1000      1.02     11.3±0.00ms        ? ?/sec    1.00     11.1±0.01ms        ? ?/sec
store_sequential_insertion_without_predicates/size_10000     1.02    113.0±0.05ms        ? ?/sec    1.00    111.0±0.06ms        ? ?/sec
store_sequential_insertion_without_predicates/size_100000    1.02   1129.9±0.61ms        ? ?/sec    1.00   1109.4±0.39ms        ? ?/sec

@deven96 deven96 force-pushed the diretnan/multiembedding-support branch 4 times, most recently from 2c25b98 to f4ab560 Compare January 4, 2026 13:48
Copy link
Collaborator

@Iamdavidonuh Iamdavidonuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lGTM. Please add a TODO to document Single and Multiple Embeddings

@deven96 deven96 force-pushed the diretnan/multiembedding-support branch from f4ab560 to f0d9d22 Compare January 4, 2026 14:10
@deven96 deven96 force-pushed the diretnan/multiembedding-support branch from f0d9d22 to 0dc3f81 Compare January 4, 2026 14:22
@deven96 deven96 merged commit 5cf2c31 into main Jan 4, 2026
6 checks passed
@deven96 deven96 deleted the diretnan/multiembedding-support branch January 4, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants