Improve tests for ParseDevfileAndValidate #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philippe Martin <[email protected]>
feloy
force-pushed
the
tests-1099/test-ParseDevfileAndValidate
branch
from
858d63a
to
194d6f7
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 60.84% 60.84%
=======================================
Files 41 41
Lines 5006 5006
=======================================
Hits 3046 3046
Misses 1767 1767
Partials 193 193 ☔ View full report in Codecov by Sentry. |
rm3l
reviewed
Sep 22, 2023
Signed-off-by: Philippe Martin <[email protected]>
feloy
force-pushed
the
tests-1099/test-ParseDevfileAndValidate
branch
from
4d4e042
to
3d08664
Compare
rm3l
approved these changes
Sep 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy, rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Adds coverage for Path, URL, RegistryURLs, DefaultNamespace, Context and K8sClient on tests for ParseDevfileAndValidate.
Which issue(s) this PR fixes:
devfile/api#1099
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Gosec scans
How to test changes / Special notes to the reviewer: