Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s.io and sigs.k8s.io direct dependencies #187

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Nov 6, 2023

What does this PR do?:

This PR help us mitigate the Rapid Reset CVE inside the devfile/library repo. It tries to update the following direct dependencies:

  • k8s.io/api: 0.26.1 => 0.26.10
  • k8s.io/apimachinery: 0.26.1 => 0.26.10
  • k8s.io/apimachinery: 0.26.1 => 0.26.10
  • k8s.io/apiextensions-apiserver: 0.26.1 => 0.26.10
  • k8s.io/client-go: 0.26.1 => 0.26.10
  • k8s.io/pod-security-admission: 0.26.1 => 0.26.10
  • sigs.k8s.io/controller-runtime: 0.14.4 => 0.14.7

These updates will lead to an update of the indirect dependency golang.org/x/net from v0.3.1-0.20221206200815-1e63c2f08a10 to 0.17.0.

Which issue(s) this PR fixes:

fixes devfile/api#1308

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.

  • Unit/Functional tests

  • QE Integration test

  • Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

  • Client Impact

  • Gosec scans

How to test changes / Special notes to the reviewer:

@thepetk thepetk self-assigned this Nov 6, 2023
@openshift-ci openshift-ci bot requested a review from feloy November 6, 2023 12:15
@openshift-ci openshift-ci bot added the approved label Nov 6, 2023
@thepetk thepetk changed the title WIP: Update k8s.io and sigs.k8s.io direct dependencies Update k8s.io and sigs.k8s.io direct dependencies Nov 6, 2023
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (393d29e) 60.84% compared to head (95b1dc0) 61.05%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   60.84%   61.05%   +0.20%     
==========================================
  Files          41       42       +1     
  Lines        5006     5017      +11     
==========================================
+ Hits         3046     3063      +17     
+ Misses       1767     1761       -6     
  Partials      193      193              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, rm3l, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 11c85d0 into devfile:main Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Library's k8s dependencies
3 participants