Skip to content

Commit

Permalink
Merge pull request #2482 from devitocodes/datasymbol
Browse files Browse the repository at this point in the history
dsl: Add ArgProvider inheritance to AbstractSymbol
  • Loading branch information
FabioLuporini authored Nov 13, 2024
2 parents 2f18ab8 + acdcb1e commit 0fe2027
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 12 deletions.
2 changes: 1 addition & 1 deletion devito/types/basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ def __new__(cls, *args, **kwargs):
__hash__ = Cached.__hash__


class DataSymbol(AbstractSymbol, Uncached):
class DataSymbol(AbstractSymbol, Uncached, ArgProvider):

"""
A unique scalar symbol that carries data.
Expand Down
3 changes: 1 addition & 2 deletions devito/types/constant.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,12 @@

from devito.exceptions import InvalidArgument
from devito.logger import warning
from devito.types.args import ArgProvider
from devito.types.basic import DataSymbol

__all__ = ['Constant']


class Constant(DataSymbol, ArgProvider):
class Constant(DataSymbol):

"""
Symbol representing a constant, scalar value in symbolic equations.
Expand Down
9 changes: 0 additions & 9 deletions devito/types/dimension.py
Original file line number Diff line number Diff line change
Expand Up @@ -570,9 +570,6 @@ def local(self):
def value(self):
return self._value

def _arg_check(self, *args, **kwargs):
pass

def _arg_values(self, grid=None, **kwargs):
# Allow override of thickness values to disable BCs
# However, arguments from the user are considered global
Expand All @@ -597,12 +594,6 @@ def _arg_values(self, grid=None, **kwargs):

return {self.name: tkn}

def _arg_finalize(self, *args, **kwargs):
return {}

def _arg_apply(self, *args, **kwargs):
pass


class AbstractSubDimension(DerivedDimension):

Expand Down

0 comments on commit 0fe2027

Please sign in to comment.