examples: Fix ADER notebook numbering #2450
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2450 +/- ##
=======================================
Coverage 87.01% 87.01%
=======================================
Files 239 239
Lines 44958 44958
Branches 8390 8390
=======================================
Hits 39118 39118
Misses 5108 5108
Partials 732 732 ☔ View full report in Codecov by Sentry. |
| @@ -5,7 +5,7 @@ | |||
| "id": "31226b14-e907-4503-9918-a09163363217", | |||
There was a problem hiding this comment.
| @@ -5,7 +5,7 @@ | |||
| "id": "31226b14-e907-4503-9918-a09163363217", | |||
There was a problem hiding this comment.
nitpicking:
Might be nicer to avoid those function and to add an option for the derivatives to "expand/simplify". so that you just need grad(div(p)) for graddiv for example.
Reply via ReviewNB
| @@ -5,7 +5,7 @@ | |||
| "id": "31226b14-e907-4503-9918-a09163363217", | |||
There was a problem hiding this comment.
Choose one you derive in the math and leave the rest outII
Something needs to be said about ABCs. It is a bit non intuitive and potentially dangerous that it doesn't need any so there needs to be some explanation why
Reply via ReviewNB
There was a problem hiding this comment.
Added an explanation. Essentially the discretisation introduces numerical diffusion where the solution is non-smooth, so when the wave hits the zero padding, it will diffuse outwards (although the zeroes never get updated).
mloubout
force-pushed
the
fix_notebook_number
branch
from
9a102aa
to
6c73a86
Compare
No description provided.