arch: Avoid deprecated compiler flags #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
- Coverage 87.18% 87.17% -0.01%
==========================================
Files 239 239
Lines 45126 45131 +5
Branches 3997 3999 +2
==========================================
+ Hits 39343 39344 +1
- Misses 5103 5106 +3
- Partials 680 681 +1 ☔ View full report in Codecov by Sentry. |
georgebisbas
reviewed
Oct 3, 2024
mloubout
reviewed
Oct 3, 2024
devito/arch/compiler.py
Outdated
| @@ -601,7 +601,7 @@ def __init_finalize__(self, **kwargs): | |||
| platform = kwargs.pop('platform', configuration['platform']) | |||
|
|
|||
| if platform is NVIDIAX: | |||
| self.cflags.append('-gpu=pinned') | |||
| self.cflags.append('-gpu=mem:separate:pinnedalloc') | |||
There was a problem hiding this comment.
probably need a version check like icx for openmp
There was a problem hiding this comment.
(@georgebisbas ) pushed tweak so that older versions are guaranteed to work
EdCaunt
approved these changes
Oct 3, 2024
FabioLuporini
force-pushed
the
avoid-deprecated-flags
branch
from
c538b5f
to
9da38e8
Compare
mloubout
approved these changes
Oct 8, 2024
mloubout
force-pushed
the
avoid-deprecated-flags
branch
from
9da38e8
to
7b1e9be
Compare
mloubout
force-pushed
the
avoid-deprecated-flags
branch
from
c9a3e4a
to
6054f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recent NVC has deprecated gpu=pinned and suggested to rather use what this patch uses