-
-
Notifications
You must be signed in to change notification settings - Fork 183
Add (incomplete) ir:USER API based on ctru-rs implementation for Circle Pad Pro support #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
syelan34
wants to merge
17
commits into
devkitPro:master
Choose a base branch
from
syelan34:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reflect libctru naming style
checksum value before returning packets.
I'm not super satisfied with my implementation of the iruserGetPackets() function, since it allocates two separate buffers, so please suggest any alternatives which might match how other libctru functions might act. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic API similar to the ir:U and ir:RST APIs, with all commands documented on 3DBrew implemented. Implementation of some functions was based on that of ctru-rs.
I don't have a circle pad pro to test with so I'm unable to check if everything works correctly, but it should match any documentation that exists.