-
-
Notifications
You must be signed in to change notification settings - Fork 8
Update GitHub Action to Node24 runtime and add explicit Node.js setup to workflows #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@rajbos 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: rajbos <[email protected]>
Co-authored-by: rajbos <[email protected]>
|
@copilot add running in a specific version of Node to the workflow(s) so that we know it works with the right version, even if the defaults change. |
Co-authored-by: rajbos <[email protected]>
Added explicit Node.js 24 setup to all workflows that build the project. This includes:
All workflows now use Commit: 5e0e152 |
rajbos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR updates the GitHub Action runtime from Node16 to Node24 to align with GitHub Actions platform migration requirements, and adds explicit Node.js version setup to all workflows to ensure consistent execution.
Changes Made
Runtime Update:
action.ymlto usenode24runtime instead ofnode16Workflow Hardening:
actions/[email protected]withnode-version: '24'to all workflows that build the project:.github/workflows/build.yml.github/workflows/testing.yml.github/workflows/publishing.yml.github/workflows/codeql.ymlWhy This Matters
The explicit Node.js setup protects against future changes to GitHub Actions runner defaults. Without this, workflows could unexpectedly break if GitHub changes the default Node.js version on runners, ensuring long-term stability and predictable builds.
Verification
@types/node: ^24.0.3)The action is now ready for the GitHub Actions platform migration to Node24 with robust workflow configuration.
Fixes #419.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.