Fix buildx install flag and enhance release workflow with manual dispatch support#129
Conversation
Co-authored-by: ChristophShyper <[email protected]>
There was a problem hiding this comment.
Pull request overview
This pull request mirrors fixes from the devops-infra/action-commit-push repository to enhance the release workflow with manual dispatch support and clean up redundant Docker Buildx configuration. The changes remove deprecated install: true parameters from buildx setup, expose a previously internal task for direct workflow use, and add duplicate tag protection that behaves differently for manual vs automated releases.
Changes:
- Removed redundant
install: truefromdocker/setup-buildx-action@v3across three workflow files (the action now installs by default) - Exposed
version:tag-releasetask by removinginternal: trueflag to enable direct workflow invocation - Added
workflow_dispatchtrigger to release workflow with smart duplicate-tag handling that gracefully skips for manual runs but fails for automated ones
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Taskfile.cicd.yml | Removed internal: true from version:tag-release task to allow direct workflow invocation |
| .github/workflows/cron-check-dependencies.yml | Removed redundant install: true parameter from buildx setup |
| .github/workflows/auto-create-release.yml | Added workflow_dispatch trigger, updated job condition, and implemented duplicate tag detection with conditional handling |
| .github/workflows/auto-create-pull-request.yml | Removed redundant install: true parameter from buildx setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| full_remote_sha="$(git ls-remote --tags origin "refs/tags/${REL_VERSION}" 2>/dev/null | awk '{print $1}' || true)" | ||
| if [ -n "${full_remote_sha}" ]; then | ||
| if [ "${GITHUB_EVENT_NAME}" = "workflow_dispatch" ]; then |
There was a problem hiding this comment.
The environment variable GITHUB_EVENT_NAME is not available by default in shell scripts. GitHub Actions exposes this value through the context variable github.event_name, but it needs to be explicitly passed to the shell environment. Add GITHUB_EVENT_NAME to the env section of this step with the value from the context.
Mirrors fixes from
devops-infra/action-commit-push(ea9308d, 67ef619, f01d240): removes redundantinstall: truefrom buildx setup, exposesversion:tag-releaseas a non-internal task, and addsworkflow_dispatchsupport with duplicate-tag protection to the release workflow.Buildx fix (
auto-create-pull-request.yml,auto-create-release.yml,cron-check-dependencies.yml)with: install: truefromdocker/setup-buildx-action@v3— redundant with current action defaultsTaskfile.cicd.ymlinternal: truefromversion:tag-releaseso it can be called directly from workflowsRelease workflow (
auto-create-release.yml)workflow_dispatchtriggerif:to pass on manual dispatch in addition to merged release PRsCreate and push git tagsstep now capturesREL_VERSIONfirst, checks remote for existing tag, and either skips gracefully (manual dispatch) or hard-fails (automated) on duplicate:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.