Skip to content

[LJU-2025] Ljubljana 25 kickoff#15165

Merged
nimbinatus merged 14 commits intodevopsdays:mainfrom
nimatel:lju-2025
May 18, 2025
Merged

[LJU-2025] Ljubljana 25 kickoff#15165
nimbinatus merged 14 commits intodevopsdays:mainfrom
nimatel:lju-2025

Conversation

@nimatel
Copy link
Contributor

@nimatel nimatel commented May 10, 2025

Ljubljana 25 kick-off

  • used script to generate Ljubljana event
  • copied logo, modified welcome page

@nimatel nimatel requested a review from a team as a code owner May 10, 2025 12:54
@netlify
Copy link

netlify bot commented May 10, 2025

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e1f589
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/6827c28a4d2e94000825215a
😎 Deploy Preview https://deploy-preview-15165--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this to the assets folder
assets/events/2025-ljubljana/logo.png

<strong>Speakers:</strong>
</div>
<div class = "col-md-8">
Do you have knowledge to share? Apply <a href="http://cfp.devopsdays.si/" target="_blank">here</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem live for now
As indicated in the next remark, please use the shortcode, to avoid out of sync links
{{< event_link url-key="cfp_link" text="here" >}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be live at a flip of a switch - please bare in mind the date. Also, we wanted to get the org site first, then the webpage and cfp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site is live, and the use of the shortcode isn't a blocker as much as a helpful practice.

Just out of curiosity, though, did you intend to use http:// instead of https:// here?

@nimatel nimatel requested a review from toshywoshy May 11, 2025 20:23
Copy link
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things (the social links mainly, and the logo move to assets) that need to be addressed. Most of my comments are more FYI and not a blocker for merge (I've tried to mark all blockers clearly for you).

@@ -0,0 +1,35 @@
+++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a note (which I'll repeat in the data file), you can delete this file and make the link at the top of your welcome page point directly to a CFP page. Just so someone doesn't stumble across this page since it's still getting built and then email your list with a proposal.

Not a blocker! Just an FYI.

@@ -0,0 +1,11 @@
+++
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as for the proposal page :)

Not a blocker; just an FYI.

<strong>Speakers:</strong>
</div>
<div class = "col-md-8">
Do you have knowledge to share? Apply <a href="http://cfp.devopsdays.si/" target="_blank">here</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site is live, and the use of the shortcode isn't a blocker as much as a helpful practice.

Just out of curiosity, though, did you intend to use http:// instead of https:// here?

<strong>Sponsors:</strong>
</div>
<div class = "col-md-9">
Position your brand. Learn about our sponsorship packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to have a link to the sponsor page here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have not finalized how sponsorship packages will look like so it's not linked - yet

event_social_twitter: "devopsdays" # Change this to the twitter handle for your event such as devopsdayschi or devopsdaysmsp
event_social_mastadon: "https://mastodon.social/@devopsdays" # Change this to url to your mastadon page
event_social_bsky: "https://bsky.app/profile/devopsdays.bsky.social" # Change this to url to your bluesky page
event_social_youtube: "devopsdays" # Change this to the youtube channel handle for your event such as devopsdaysrox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker: Please change this to your city's page or comment out.

event_social_bsky: "https://bsky.app/profile/devopsdays.bsky.social" # Change this to url to your bluesky page
event_social_youtube: "devopsdays" # Change this to the youtube channel handle for your event such as devopsdaysrox
# legacy
event_twitter: "devopsdays" # This will create a traditional "Follow" twitter button. Change this to the twitter handle for your event such as devopsdayschi or devopsdaysmsp.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the right link; please update or comment out

event_twitter: "devopsdays" # This will create a traditional "Follow" twitter button. Change this to the twitter handle for your event such as devopsdayschi or devopsdaysmsp.

nav_elements: # List of pages you want to show up in the navigation of your page.
# - name: propose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you'd like to change the link in the header and then remove the markdown for the page as I mentioned in a previous comment, here's how:

Suggested change
# - name: propose
- name: propose
url: <insert-url-here>

Not a blocker; just an FYI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you check the preview, the logo isn't showing up on the main page: https://deploy-preview-15165--devopsdays-web.netlify.app/

Please copy this file to assets/events/2025-ljubljana to have it appear properly on the main page.

@nimbinatus nimbinatus added the changes-requested Changes have been requested, and are pending updates. label May 16, 2025
@nimatel nimatel requested a review from nimbinatus May 16, 2025 22:47
Copy link
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the logo broken on the welcome page (reference the review), everything looks great. Since the content is there, I'm merging. Please open a PR to patch the logo display on your welcome page when you can.


<div class="row" style="background-color: #f8f9fa; padding: 20px; border-radius: 8px; box-shadow: 0 4px 8px rgba(0, 0, 0, 0.1);">
<div class="col-md-4" style="text-align: center;">
<img alt="DevOpsDays Ljubljana 2025" src="/events/2025-ljubljana/logo-square.jpg" class="img-fluid" style="max-width: 100%; border-radius: 8px;">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this image isn't displaying with the move to assets. The short code Tosh mentioned is what you can use here to have it display. I'm reviewing on mobile, so I apologize that I don't have the link to how to use it handy. I know you all need this merged soon, so I'm approving and merging. Open a PR with the patch for getting the logo displaying, and we'll get it merged, too

@nimbinatus nimbinatus merged commit fc02cd8 into devopsdays:main May 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes-requested Changes have been requested, and are pending updates.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants