feat(download): add download env var#3159
Open
GiladTrachtenberg wants to merge 3 commits intodevspace-sh:mainfrom
Open
feat(download): add download env var#3159GiladTrachtenberg wants to merge 3 commits intodevspace-sh:mainfrom
GiladTrachtenberg wants to merge 3 commits intodevspace-sh:mainfrom
Conversation
GiladTrachtenberg
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #3106
Please provide a short message that should be published in the DevSpace release notes
Added the option to designate a specific download directory/folder with an environment variable
What else do we need to know?
There seems to be an issue (unrelated to my changes - tested with and without them as well as directly from main) with testing the helm download (coverage - unit test):
[...] --- FAIL: TestHelmDownload (0.51s) engine_test.go:135: assertion failed: expression is false: strings.Contains(stdout1.String(), `Version:"v3`) FAIL coverage: 65.4% of statements FAIL github.com/loft-sh/devspace/pkg/devspace/pipeline/engine 1.076s FAIL github.com/loft-sh/devspace/pkg/devspace/pipeline/engine/basichandler coverage: 0.0% of statements [...]