Skip to content

fix: interface implementation for RunCommand #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 17, 2024
Merged

fix: interface implementation for RunCommand #144

merged 14 commits into from
Jun 17, 2024

Conversation

prkhrkat
Copy link
Contributor

@prkhrkat prkhrkat commented Jun 3, 2024

Copy link

gitguardian bot commented Jun 10, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
7200613 Triggered Generic High Entropy Secret fe2e6bb test-data/testJson.go View secret
7489395 Triggered GitHub Access Token fe2e6bb test-data/testJson.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Quality Gate Passed Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kripanshdevtron kripanshdevtron changed the title interface implementation for RunCommand fix: interface implementation for RunCommand Jun 17, 2024
@prkhrkat prkhrkat merged commit 0363f28 into main Jun 17, 2024
1 check passed
@prkhrkat prkhrkat deleted the secret-dev branch June 17, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants