Skip to content

misc: Removing default value of idleReplicaCount #6730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

YashasviDevtron
Copy link
Contributor

@YashasviDevtron YashasviDevtron commented Jul 15, 2025

Description

Fixes #6733

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

This pull request removes the default idleReplicaCount field from the Helm chart configuration and updates the customPodLabels configuration. The changes aim to streamline deployment settings for better maintainability and clarity by cleaning up unnecessary defaults and resolving conflicting configurations.

Copy link

bito-code-review bot commented Jul 15, 2025

Code Review Agent Run #44f490

Actionable Suggestions - 0
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

  • scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml - 1
    • KEDA configuration field removal breaks template · Line 127-127
Review Details
  • Files reviewed - 1 · Commit Range: 5f200f5..5f200f5
    • scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

Copy link

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Other Improvements - Miscellaneous Configuration Updates

values.yaml - Removed idleReplicaCount default and adjusted customPodLabels configuration for clearer deployment settings.

@YashasviDevtron YashasviDevtron merged commit 286d64c into main Jul 15, 2025
15 checks passed
@YashasviDevtron YashasviDevtron deleted the deployment-chart-keda-1 branch July 15, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Removing IdleReplicaCount from deafult values.yaml
2 participants