Deployment chart keda

[YashasviDevtron]

Description

Fixes #

Checklist:

• The title of the PR states what changed and the related issues number (used for the release note).
• Does this PR requires documentation updates?
• I've updated documentation as required by this PR.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have tested it for all user roles.
• I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?

Summary by Bito

The pull request implements comprehensive improvements across the codebase, addressing type consistency and error handling in user attributes and API token services, while modernizing event payload generation. It updates dependency references and refines package imports for enhanced maintainability. The modifications integrate advanced JSON parsing and merging mechanisms in the attributes service.

[github-actions]

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.9% Duplication on New Code

See analysis details on SonarQube Cloud

[bito-code-review]

Changelist by Bito

This pull request implements the following key changes.

Key Change	Files Impacted
Bug Fix - User Attributes and API Initialization Corrections	- UserAttributesRestHandler.go - Updated type signatures to use bean.UserAttributesDto for improved data consistency. - wire_gen.go - Revised ApiTokenService initialization to handle errors properly.
Other Improvements - Dependency and Import Enhancements	- ArgoClientWrapperService.go - Switched retryFunc import to the common-lib utils, removing deprecated usage. - go.mod - Adjusted dependency versions for authenticator and common-lib to their updated releases. - go.sum - Reflected module checksum updates corresponding to the dependency version changes.
Feature Improvement - Event, Token, and Attributes Service Upgrades	- EventClient.go - Migrated event payload creation to the v2 implementation and removed legacy notifier flag. - ApiTokenService.go - Enhanced token service with configuration support and improved error logging. - UserAttributesService.go - Refactored service to use bean types and introduced robust JSON merging for user attributes.
Testing - User Attributes Service Test Enhancements	- UserAttributesService_test.go - Added comprehensive test cases to validate merge logic and resource initialization in user attributes service.
Feature Improvement - Adapter Enhancement for User Attributes	- adapter.go - Introduced BuildResponseDTO function to construct UserAttributesDto leveraging bean definitions.
Feature Improvement - Bean Definitions Enhancement	- bean.go - Introduced UserPreferencesResourcesKey constant and added UserAttributesDto type for better data handling.
Feature Improvement - Build Trigger Service Flag Enhancements	- HandlerService.go - Refactored build trigger services to use BuildxGlobalFlags, updating workflow request handling for build cache improvements. - HandlerService_ent.go - Updated build trigger service endpoint to incorporate new BuildxGlobalFlags configuration.
Other Improvements - Git Operations Retry Mechanism Update	- GitOperationService.go - Updated retry function usage and error handling for Git commit operations. - GitServiceAzure.go - Optimized retryFunc import for Azure Git service interactions. - GitServiceBitbucket.go - Replaced deprecated retryFunc usage with common-lib version for Bitbucket service. - GitServiceGithub.go - Refined retry mechanism by updating retry function import in GitHub service. - GitServiceGitlab.go - Switched to common-lib retryFunc for improved error handling in GitLab service.
Feature Improvement - Workflow Configuration Enhancement	- Workflow.go - Added BuildxInterruptionMaxRetry field to workflow request types for improved build management.
Bug Fix - Deployment Chart Configuration Corrections	- values.yaml - Removed redundant idleReplicaCount and standardized autoscaling settings.

[bito-code-review]

Code Review Agent Run #ae4fc3

Actionable Suggestions - 1

• pkg/attributes/UserAttributesService.go - 1

  • Missing UserId field in response DTO · Line 265-265

Review Details

• Files reviewed - 21 · Commit Range: a93ab0e..4dfe4f8

  • api/restHandler/UserAttributesRestHandler.go
  • client/argocdServer/ArgoClientWrapperService.go
  • client/events/EventClient.go
  • cmd/external-app/wire_gen.go
  • go.mod
  • go.sum
  • pkg/apiToken/ApiTokenService.go
  • pkg/attributes/UserAttributesService.go
  • pkg/attributes/UserAttributesService_test.go
  • pkg/attributes/adapter/adapter.go
  • pkg/attributes/bean/bean.go
  • pkg/build/trigger/HandlerService.go
  • pkg/build/trigger/HandlerService_ent.go
  • pkg/deployment/gitOps/git/GitOperationService.go
  • pkg/deployment/gitOps/git/GitServiceAzure.go
  • pkg/deployment/gitOps/git/GitServiceBitbucket.go
  • pkg/deployment/gitOps/git/GitServiceGithub.go
  • pkg/deployment/gitOps/git/GitServiceGitlab.go
  • pkg/pipeline/types/Workflow.go
  • scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/values.yaml
  • wire_gen.go
• Files skipped - 3

  • env_gen.json - Reason: Filter setting
  • env_gen.md - Reason: Filter setting
  • vendor/modules.txt - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • SNYK (Security Vulnerability) - ✔︎ Successful
  • GOVULNCHECK (Security Vulnerability) - ✖︎ Failed
  • OWASP (Security Vulnerability) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Missing UserId field in response DTO

Missing UserId field assignment in GetUserAttribute response DTO construction. The bean.UserAttributesDto struct includes a UserId field, but it's not being set in the response, causing incomplete data to be returned. Add UserId: request.UserId, to the struct initialization.

Code suggestion

Check the AI-generated fix before applying

 @@ -265,6 +265,7 @@
  	resAttrDto := &bean.UserAttributesDto{
  		EmailId: request.EmailId,
  		Key:     request.Key,
  		Value:   modelValue,
 +		UserId:  request.UserId,
  	}
  	return resAttrDto, nil

Code Review Run #ae4fc3

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them

[github-actions]

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n