Skip to content

misc: Removing default value of idleReplicaCount #6732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

YashasviDevtron
Copy link
Contributor

@YashasviDevtron YashasviDevtron commented Jul 15, 2025

Description

Fixes #6729

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit/api test cases.

Does this PR introduce a user-facing change?


Summary by Bito

The pull request updates helm chart values files by removing default idleReplicaCount settings and adjusting related parameters in both deployment and reference charts. The changes aim to streamline configurations to prevent potential misconfigurations during deployments while enhancing consistency and reliability.

Copy link

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n

Copy link

bito-code-review bot commented Jul 15, 2025

Code Review Agent Run #678816

Actionable Suggestions - 0
Filtered by Review Rules

Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.

  • scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml - 1
    • Missing required KEDA configuration parameter · Line 127-127
  • scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/values.yaml - 1
    • Missing required KEDA configuration parameter · Line 130-130
Review Details
  • Files reviewed - 2 · Commit Range: 96ef454..e4295b7
    • scripts/devtron-reference-helm-charts/deployment-chart_4-21-0/values.yaml
    • scripts/devtron-reference-helm-charts/reference-chart_5-1-0/values.yaml
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].

Documentation & Help

AI Code Review powered by Bito Logo

Copy link

Some linked issues are invalid. Please update the issue links:\nIssue #6729 in devtron-labs/devtron is not found or invalid (HTTP 403).\n

Copy link

Changelist by Bito

This pull request implements the following key changes.

Key Change Files Impacted
Bug Fix - Bug Fixes in Deployment Charts

values.yaml - Removed the default idleReplicaCount value and updated the autoscaling containerResource enabled flag to correct configuration settings.

values.yaml - Removed the default idleReplicaCount value and refined the customPodLabels configuration for consistency.

@YashasviDevtron YashasviDevtron changed the title fix: Removing default value of idleReplicaCount misc: Removing default value of idleReplicaCount Jul 15, 2025
Copy link

Copy link

bito-code-review bot commented Jul 15, 2025

Bito Review Skipped - No Changes Detected

Bito didn't review this pull request because we did not detect any changes in the pull request to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants