-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beta omnibox integration. #103
base: dev
Are you sure you want to change the base?
Conversation
@artemgrygor Dude! This is so awesome. great work on getting this implemented! |
Hi guys, P.S. Sometimes it's necessary to reload extension to see the last version. So if you don't see "Search Dewey for...", please reload the extension and clear cache. |
Artem, this is awesome. I love the option to pass a search into dewey or head directly to a bookmark. Good work. It does seem a bit slow, though. I had some trouble after typing a search term and hitting enter without waiting a couple of seconds so it would return, something like "sear" after I had put "searchterm" in the input. Hope that makes sense :) Overall this is really cool! One other idea i had, was to use |
Cool! I like it too, it rapidly increases user experience for me. I agree with "dew" problem. We need to find some other solutions. Maybe "dew:" or what do you like? You can change the keyword at manifest.json and try different variants. I will have a look what we can do with performance. |
What about a symbol like @ or #? They're easily accessible and unlikely to run into interference. |
@berfarah Ah, yea that's a good idea. But the Too bad, cause the at symbol makes a lot of sense to me here. Using the hash could work too. I'll look into the others have handled this too. Let me know if you guys run into anything as well. Thanks dudes! |
Maybe just |
@jamiewilson changed to '-d'. Playing with it around day, for now seems the best and fastest. Also trying to use '=d' because there is not necessary to hold Shift. |
@artemgrygor Hey, sounds good. Did you mean that you need to hold shift to get a dash? For me both dash and equal signs do not require shift. |
@jamiewilson sorry, was misunderstanding with '@d' and '#d'. The '-d' is good. |
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Conflicts: js/controllers/main.js manifest.json
Conflicts: js/directives/updateBackground.js manifest.json
Hi guys,
this is a first beta Omnibox integration. Please have a look and try it.
I'm trying to implement opening Dewey from Omnibox. And then apply our boolean search.