Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta omnibox integration. #103

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

Conversation

artemgrygor
Copy link
Contributor

Hi guys,
this is a first beta Omnibox integration. Please have a look and try it.
I'm trying to implement opening Dewey from Omnibox. And then apply our boolean search.

@jamiewilson
Copy link
Member

@artemgrygor Dude! This is so awesome. great work on getting this implemented!

@artemgrygor
Copy link
Contributor Author

Hi guys,
I've finished beta version for the omnibox integration. Please have a look and make proposals.
What we have now:
-first default action "Search Dewey for: SEARCHTEXT". This action opens extension with pre-defined SEARCHTEXT
-list of suggestions. Each action opens direct link to bookmark.

P.S. Sometimes it's necessary to reload extension to see the last version. So if you don't see "Search Dewey for...", please reload the extension and clear cache.

@jamiewilson
Copy link
Member

Artem, this is awesome. I love the option to pass a search into dewey or head directly to a bookmark. Good work. It does seem a bit slow, though. I had some trouble after typing a search term and hitting enter without waiting a couple of seconds so it would return, something like "sear" after I had put "searchterm" in the input. Hope that makes sense :) Overall this is really cool!

One other idea i had, was to use d_ or something like that. The reason is that if someone's omnibox suggests deweyapp.io, you would have to delete eyapp.io every time before hitting tab. Although I see how dew is much easier to remember. Let me know what you think.

@artemgrygor
Copy link
Contributor Author

Cool! I like it too, it rapidly increases user experience for me. I agree with "dew" problem. We need to find some other solutions. Maybe "dew:" or what do you like? You can change the keyword at manifest.json and try different variants. I will have a look what we can do with performance.

@berfarah
Copy link

berfarah commented Aug 8, 2014

What about a symbol like @ or #? They're easily accessible and unlikely to run into interference.

@jamiewilson
Copy link
Member

@berfarah Ah, yea that's a good idea. But the @ at the beginning still causes the same problem for me though.

screenshot 2014-08-08 09 21 12

Too bad, cause the at symbol makes a lot of sense to me here. Using the hash could work too. I'll look into the others have handled this too. Let me know if you guys run into anything as well. Thanks dudes!

@jamiewilson
Copy link
Member

Maybe just -d ?

@artemgrygor
Copy link
Contributor Author

@jamiewilson changed to '-d'. Playing with it around day, for now seems the best and fastest. Also trying to use '=d' because there is not necessary to hold Shift.

@jamiewilson
Copy link
Member

@artemgrygor Hey, sounds good. Did you mean that you need to hold shift to get a dash? For me both dash and equal signs do not require shift.

@jamiewilson jamiewilson mentioned this pull request Aug 14, 2014
@jamiewilson jamiewilson added this to the 3.0 milestone Aug 14, 2014
@artemgrygor
Copy link
Contributor Author

@jamiewilson sorry, was misunderstanding with '@d' and '#d'. The '-d' is good.

artemgrygor and others added 9 commits November 24, 2014 01:15
# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
Conflicts:
	js/controllers/main.js
	manifest.json
Conflicts:
	js/directives/updateBackground.js
	manifest.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants