fix: fix oauth connector type failing with BadRequest #4194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwanad
force-pushed
the
fix-oauth2-connectors
branch
from
247eb14 to
d9bcc14
Compare
Signed-off-by: Marwan Ahmed <[email protected]>
marwanad
force-pushed
the
fix-oauth2-connectors
branch
from
d9bcc14 to
c42cba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Any connector with
oauthtype would fail with a400 Bad Requestand aRequested resource does not exist.because it doesn't implement any of the connector type interfaces. Requests to/auth/{connector_id}would all fail.dex/server/handlers.go
Lines 309 to 311 in 7208747
What this PR does / why we need it
Special notes for your reviewer