chore: check for prompt=none in authentication requests #4325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for
prompt=noneas described in the specs section 3.1.2.1.What this PR does / why we need it
Currently dex lacks support for the
prompt=noneparameter. Thoughpromptis an optional parameter in the request, if it is set tononethe IdP must not show any login mask or other UIs. Instead it should either return a new token if the session is still valid or return an error (which is always the case for dex, as there are no sessions).This PR adds support for
prompt=nonein a way which will check for the existence of the parameter and the value and if that is the case, it always returns alogin_requirederror.