fix: add dedicated go.mod for /v2 to fix /v2 imports #4370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g backward compatibility Signed-off-by: Tyler Gillson <[email protected]>
|
@nabokihms Hi! Can you review this simple PR which fixed go mod v2 compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Applies the major version subdirectory approach to fixing dex's currently broken usage of major version release tags without a corresponding major version in go.mod.
This approach maintains backward compatibility with current projects importing pseudo versions.
What this PR does / why we need it
Closes #4222
Special notes for your reviewer
govulncheckshould stop flagging https://pkg.go.dev/vuln/GO-2024-2476#versions-note once this is merged and a new release is published.