-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: DEP #32 "Remember me" for Password-based Connectors #4381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
784ef6d to
3b8ba2b
Compare
revert snapshot fix lint error snaphost snapshot Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
... Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
81e540e to
48728cc
Compare
|
@nabokihms @sagikazarmark I think you have to add a label for me because I cannot do that. Would be appreciated. |
| @@ -0,0 +1,27 @@ | |||
| Goal is to come up with a compact and minimal design for https://github.com/dexidp/dex/issues/32 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Remove this file, this was just my scratch pad to gather my thoughts.
|
I looked through this PR briefly. As was mentioned, this feature requires the sessions concept and the way of storing them. There are other possible features that can benefit from it, like SSO or 2FA, but moving towards a simple in-memory store will make this thing unextendible in the future.Let's discuss the session implementation first and then move forward with the remember me feature. |
In general I agree with your notion, so it's a yes but I would have the following suggestion(s):
|
Overview
kind/enhancement
Build concept/solution for #32
What this PR does / why we need it
For details refer to
docs/enhancements/remember-me-2025-10-19-#32.mdCloses #32
Special notes for your reviewer