Skip to content

Conversation

@daemonfire300
Copy link
Contributor

@daemonfire300 daemonfire300 commented Oct 17, 2025

Overview

kind/enhancement

Build concept/solution for #32

What this PR does / why we need it

For details refer to docs/enhancements/remember-me-2025-10-19-#32.md

Closes #32

Special notes for your reviewer

@daemonfire300 daemonfire300 force-pushed the jf-remember-me branch 6 times, most recently from 784ef6d to 3b8ba2b Compare October 18, 2025 20:15
@daemonfire300 daemonfire300 changed the title remember me DEP #32 "Remember me" for Password-based Connectors Oct 22, 2025
revert

snapshot

fix lint error

snaphost

snapshot

Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
Signed-off-by: Julius Foitzik <[email protected]>
@daemonfire300 daemonfire300 marked this pull request as ready for review October 22, 2025 16:41
@daemonfire300 daemonfire300 changed the title DEP #32 "Remember me" for Password-based Connectors feat: DEP #32 "Remember me" for Password-based Connectors Nov 1, 2025
@daemonfire300
Copy link
Contributor Author

@nabokihms @sagikazarmark I think you have to add a label for me because I cannot do that. Would be appreciated.

@@ -0,0 +1,27 @@
Goal is to come up with a compact and minimal design for https://github.com/dexidp/dex/issues/32
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove this file, this was just my scratch pad to gather my thoughts.

@nabokihms
Copy link
Member

I looked through this PR briefly. As was mentioned, this feature requires the sessions concept and the way of storing them. There are other possible features that can benefit from it, like SSO or 2FA, but moving towards a simple in-memory store will make this thing unextendible in the future.Let's discuss the session implementation first and then move forward with the remember me feature.

@daemonfire300
Copy link
Contributor Author

I looked through this PR briefly. As was mentioned, this feature requires the sessions concept and the way of storing them. There are other possible features that can benefit from it, like SSO or 2FA, but moving towards a simple in-memory store will make this thing unextendible in the future.Let's discuss the session implementation first and then move forward with the remember me feature.

In general I agree with your notion, so it's a yes but I would have the following suggestion(s):

  1. Intentionally did it in memory only to avoid complexity, because this did not cost that much and does not introduce such a big maintenance burden. So I would be in favor to have a two phase solution, if possible, where we have a in memory remember version out first (soon-ish) and have 80% of the benefit of 20% of the work and then use that cushion to work on a generic/extended session concept.
  2. Would you like to have an initial Teamspeak/Discord/Signal/Matrix/Google Meet call between us or more people to get on common ground and then start writing proposals?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Remember me" when logging in

2 participants