fix: handle url fragments for redirects #4464
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Includes original URL fragment throughout auth process to keep it in the original redirect.
What this PR does / why we need it
Closes #4462
Including the URL fragment on the pages that do form posts to different URL (not to self) and anchor links to providers.
Special notes for your reviewer
What are implications of adding the hash to the URLs on the login.html page. Do some providers use the hash and if so this will mess up the url fragment. Maybe we should only add it to the password.html page.
Tested manually using the following flow:
./bin/dex serve examples/config-dev.yamlcd examples && go run ./example-apphttp://127.0.0.1:5555/click login#foobarto the URL and force refresh#foobarto the URL and force refresh[email protected]andpasswordand observe the fragment is still there after being redirected.