Only write the dependency tree output file if it has changed #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #167 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 32 32
Lines 3751 3763 +12
=======================================
+ Hits 3748 3760 +12
Misses 3 3
🚀 New features to boost your workflow:
|
ahmdmhasn
approved these changes
Jun 3, 2025
| @@ -52,6 +52,13 @@ struct SafeDITool: AsyncParsableCommand, Sendable { | |||
| throw ValidationError("Must provide 'swift-sources-file-path', '--include', or '--include-file-path'.") | |||
| } | |||
|
|
|||
| async let existingGeneratedCode: String? = Task.detached { | |||
| if let dependencyTreeOutput { | |||
| try? String(contentsOf: dependencyTreeOutput.asFileURL, encoding: .utf8) | |||
There was a problem hiding this comment.
Do we need to log if unable to initialize a string with the content of the tree output? Anyway, it should be nil for initialization errors, or the file doesn't exist initially.
There was a problem hiding this comment.
I don't think so – if we can't read it for whatever reason we'll just write a new one.
| if let dependencyTreeOutput, let generatedCode = try await generatedCode { | ||
| if let dependencyTreeOutput, | ||
| let generatedCode = try await generatedCode, | ||
| // Only update the file if the file has changed. |
Co-authored-by: Ahmed M. Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ahmdmhasn had a great idea to not touch the output file if the output file's content hasn't changed. Looks like modern Xcode seems to support having a package plugin that does supports this, so let's do it.
I believe earlier SPM implementations required the output file to be touched as part of the build plugin run, so we needed to write the file. This does not seem to be the case in Xcode 16+.