fix: use async sockets for async SSH connections #8438
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierugo-dfinity
added
the
CI_ALL_BAZEL_TARGETS
andrewbattat
approved these changes
Jan 21, 2026
frankdavid
reviewed
Jan 21, 2026
basvandijk
approved these changes
Jan 21, 2026
eichhorl
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes use of a tokio socket for SSH connections created from an async context. This should fix the flakiness of
nr_largeas sockets won't block like they used to anymore, see the relevant Slack thread. Tried a few times locally successfully.Note: this change would break
upgradetests when streaming the replica logs to see if the orchestrator shut down gracefully. We thus use a synchronous socket instead.