Merged
Conversation
basvandijk
reviewed
Feb 5, 2026
basvandijk
approved these changes
Feb 5, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2026
Add a publish crates workflow, so that teams can publish their crates with a trusted workflow and not manually. Will work with teams individually, to see if modifications need to be made.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nmattia
reviewed
Feb 5, 2026
Comment on lines
+38
to
+39
| cargo build --package ${{ github.event.inputs.crate-name }} | ||
| cargo test --package ${{ github.event.inputs.crate-name }} |
Contributor
There was a problem hiding this comment.
would it make sense to run this on more platforms? also, shouldn't we assume that the crate has its own build & test as part of regular CI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a publish crates workflow, so that teams can publish their crates with a trusted workflow and not manually.
Will work with teams individually, to see if modifications need to be made.