Skip to content

chore(IDX): improve handling of runfiles in system-tests #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
basvandijk wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

chore(IDX): improve handling of runfiles in system-tests #8449

basvandijk wants to merge 5 commits into from
+35 −7

Conversation

@basvandijk
Copy link
Collaborator

@basvandijk basvandijk commented Jan 21, 2026

WIP

@github-actions github-actions bot added the chore label Jan 21, 2026
basvandijk
basvandijk commented Jan 21, 2026
View reviewed changes
rs/tests/run_systest.sh
read -ra test_driver_extra_args <<<"${RUN_SCRIPT_DRIVER_EXTRA_ARGS:-}"

# Copy all runtime_deps into "$TEST_TMPDIR/runfiles"
# and reset the env vars pointing to the new location using absolute paths.
Copy link
Collaborator Author

@basvandijk basvandijk Jan 21, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: I'm not sure yet whether to go with absolute or relative paths.

  • Absolute paths have the minor advantage that we don't need to export $RUNFILES.

  • Relative paths have the advantage of being consistent with Bazel and that for colocated tests we can just copy $RUNFILES to the colocated test-driver and point RUNFILES to the copied directory and be done with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@basvandijk