Skip to content

Feature/add laser scan data #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

RavisankarSelvaraju
Copy link

Add a functionality to send laserscan data between ROS2 and ROCK

@planthaber
Copy link
Member

Good addition, can you add some fields to the LaserScan type to make it also compatible with the DepthMap type (2-dimenmsional LaserScan)? No need to add the conversion yet)

https://github.com/rock-core/base-types/blob/master/src/samples/DepthMap.hpp

  • timestamp
  • uint vertical_size
  • uint horizontal_size
  • y angle resolution
  • repeated float for remission values

For single lines, as in your current LaserScan massage the vertical_size can just be 0, horizontal_size =1;

@RavisankarSelvaraju
Copy link
Author

RavisankarSelvaraju commented Jul 8, 2025

The timestamp is already included in the header msg which is included in the laserscan msg so i did not include that in the updated LaserScan msg, if it is particularly needed, i can add that too.
Also i changed the old angle_resolution to horizontal_angle_resolution
instead of y angle resolution, i added vertical_angle_resolution to be more in line with the horizontal and vertical size

@planthaber
Copy link
Member

Didn't see the header ;-)

@planthaber planthaber self-requested a review July 8, 2025 10:57
@planthaber planthaber merged commit cbff155 into dfki-ric:master Jul 8, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants