-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typescript definitions & package.json config #196
Open
abeven
wants to merge
6
commits into
dgrubelic:master
Choose a base branch
from
abeven:add_ts_defs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeven
commented
Feb 20, 2020
- Adds TS definitions by @ilari_makimattila in Add typescript types #136
- Adds some entries to package.json to help editors find the definitions
- Augments Vue definition to include an $auth property
Hi @abeven , thx for this. I like it and will review and check it tomorrow. |
You rock thank you.
…On Thu, Feb 20, 2020, 5:39 PM Davor Grubelić ***@***.***> wrote:
Hi @abeven <https://github.com/abeven> , thx for this. I like it and will
review and check it tomorrow.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#196?email_source=notifications&email_token=AAG636G44BKZJRF5RQWJMPLRD4BDDA5CNFSM4KYWX2N2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMQVQUY#issuecomment-589387859>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG636FFHR66AEEERCAW5BLRD4BDDANCNFSM4KYWX2NQ>
.
|
Any chance we can get this merged and released soonish? It's kinda killing me at the moment. 😞 |
@dgrubelic do you plan on reviewing this PR? |
Might be worth pushing these types to https://github.com/DefinitelyTyped/DefinitelyTyped in the short term? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.