Skip to content

Conversation

dgtlmoon
Copy link
Owner

@dgtlmoon dgtlmoon commented Apr 30, 2025

Re
#821
#1118
#1534
#2866
#3159
#3426
#3357
#3366

#2981

#2109 (comment)

  • Make the "preview" auto fetch the rendered text on click
  • "send test" and others need some icon and change of colour for each one (hard to read)
  • When customising a watch it seems to skip the UUID for generating the preview for now
  • fix the 'groups' / tag notification settings too
  • use iframe for preview so we can pump rendered HTML into it
  • checking cascading vars for setting notification type ( global > group > individual )
  • check watch_title is correct
  • check escaped strings (see comment)
  • check {% now 'America/New_York', '%Y-%m-%d' %} works watch, main, group settings (needs test that now is OK)
  • check notification wrapper template works - lets leave it out for now/disabled
  • manually check {{triggered_text}} token holder
  • and this [feature] improve test coverage for tags and notification test #3032
  • and [feature] Minor UI tweak - disable word wrap in notification settings #2133
  • diff_added and diff_removed not switching to html color (maybe other modes)
  • when in non-html mode, if i enter say <strong>diff </strong> it should escape it in the preview, actually use .text of another div instead?
image

Future

  • some mode to setup a default email server and make it nicer to add notifications

@dgtlmoon dgtlmoon changed the title Re #3159 - better send test handling Re #3159 - Notifications improvement Aug 22, 2025
@dgtlmoon dgtlmoon changed the title Re #3159 - Notifications improvement Re #3159 - Notifications UI fixes and improvement Aug 22, 2025
@dgtlmoon
Copy link
Owner Author

image

i think the diff needs to be escaped first, in this text there is a change containing "<title>"..

@dgtlmoon
Copy link
Owner Author

dgtlmoon commented Sep 18, 2025

image

something odd on edit watch

curl 'http://127.0.0.1:5000/notification/render-preview/3e82c4fd-81b1-401a-849d-ababfb4843bd' \
  -H 'Accept: */*' \
  -H 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8,cs;q=0.7,it;q=0.6' \
  -H 'Connection: keep-alive' \
  -H 'Content-Type: application/x-www-form-urlencoded; charset=UTF-8' \
  -b 'token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6IjNmMTI5YmE1LWM0ZjMtNDM0Yi04NDg2LTU2ZTY5ZTc2ZDI4YSJ9.MoyTdpn2lmFtNVVSJjJnm7BOcZa-uuCYkXYXtAs94YE; _ga=GA1.1.1410802421.1743158400; _ga_FYBJ4CJDKF=GS1.1.1743158399.1.1.1743159108.0.0.0; sort=last_changed; order=asc; _gcl_au=1.1.34609819.1753095481; _ga_4J95S1QY84=GS2.1.s1754378263$o22$g1$t1754378264$j59$l0$h0; _ga_89T7TFLH0B=GS2.1.s1754378263$o22$g1$t1754378265$j58$l0$h0; [email protected]|c0794124f8f11d5881e1b94f8c4db8465a187770fe44382dd3289f8fb854a2341c6666eeba4a8767e818dc0a798d10399fe992965674f435a7903ea0286402c7; css_dark_mode=false; session=eyJfZnJlc2giOmZhbHNlLCJjc3JmX3Rva2VuIjoiNjE2MThkMjk4MmNhODg2MDlhNDRmNGY3MTZjMmQwYjI4NjEyNGQwZCJ9.aMuxzA.YUWWUssPzEJAWMkMNUb2XHAzaHc' \
  -H 'DNT: 1' \
  -H 'Origin: http://127.0.0.1:5000' \
  -H 'Referer: http://127.0.0.1:5000/edit/3e82c4fd-81b1-401a-849d-ababfb4843bd' \
  -H 'Sec-Fetch-Dest: empty' \
  -H 'Sec-Fetch-Mode: cors' \
  -H 'Sec-Fetch-Site: same-origin' \
  -H 'User-Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/139.0.0.0 Safari/537.36' \
  -H 'X-CSRFToken: IjYxNjE4ZDI5ODJjYTg4NjA5YTQ0ZjRmNzE2YzJkMGIyODYxMjRkMGQi.aMu1rg.GH_6dza_U_Y8KJ3LXQVIYdYn2vw' \
  -H 'X-Requested-With: XMLHttpRequest' \
  -H 'sec-ch-ua: "Chromium";v="139", "Not;A=Brand";v="99"' \
  -H 'sec-ch-ua-mobile: ?0' \
  -H 'sec-ch-ua-platform: "Linux"' \
  --data-raw 'notification_body=%7B%7Bdiff_added%7D%7D&notification_format=System+default&notification_title=lasdjfkajfs&notification_urls=&tags=error&window_url=http%3A%2F%2F127.0.0.1%3A5000%2Fedit%2F3e82c4fd-81b1-401a-849d-ababfb4843bd%23notifications'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant