Skip to content

Conversation

dgtlmoon
Copy link
Owner

@dgtlmoon dgtlmoon commented Oct 15, 2025

Closes #3505
Related to

This adds a new filter field shown only in restock mode price_change_custom_include_filters, which is separate to the include_filters of the content change filter mode

todo

  • fix: instock/soldout indicator does not update in realtime.js
  • fix: textarea for selector should be a single line input
  • implement: instock/soldout indicator should have a third state cant decide or similar for restock detection
  • implement: text above visual-selector needs a message "you are overriding the automatic detection"
  • implement: any error messages from restock detector should give you an easy link to the visual selector option (too many prices, etc)
  • implement: needs automated test of price_change_custom_include_filters selector for the price data
  • add test for wild strings like 'Beginning at 1 099,00 € tax incl. tax incl.' that they correct convert price and currency (EUR shown)
  • out of stock detector should still run on the page
  • should still throw 'filter not found' trigger to alert you that the filter doesnt found anymore

this is going to break/not work when this case happens.. because either new 'discount' element is going to go missing once the price returns.. so its not a great solution i think

image

Anyway, here's how it looks

image image image

@dgtlmoon
Copy link
Owner Author

@Batwam please absolutely do not write irrelevant things in the issue queue, submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Use "visual filters" for price/restock mode?

1 participant