Skip to content

fix: bundle master for analytics apps #17888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

janhenrikoverland
Copy link
Contributor

@janhenrikoverland janhenrikoverland commented Jun 26, 2024

The dev branch of our apps should never be bundled. It's a staging branch before we release to master. And FYI, we're about to remove these dev branches.

@amcgee
Copy link
Member

amcgee commented Jun 26, 2024

Adding @Philip-Larsen-Donnelly as reviewer for FYI and to update any necessary scripts (if they exist)

Copy link
Contributor

@Philip-Larsen-Donnelly Philip-Larsen-Donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The "dev" was meant to be a temporary change towards the end of v41 development.

@janhenrikoverland janhenrikoverland enabled auto-merge (squash) June 28, 2024 14:14
Copy link

@janhenrikoverland janhenrikoverland merged commit 789a638 into 2.41 Jun 28, 2024
13 checks passed
@janhenrikoverland janhenrikoverland deleted the fix/bundle-master-analytics branch June 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants