chore: remove dhis-api EventService.addEvent DHIS2-17677 #17917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
changed the title
teleivo
force-pushed
the
DHIS2-17638-3
branch
2 times, most recently
from
aea83a9 to
5f823a0
Compare
teleivo
changed the title
teleivo
force-pushed
the
DHIS2-17638-3
branch
4 times, most recently
from
f770e9b to
6d79239
Compare
as except for 1 usage in the EventService itself (inlined) it was only used in tests.
|
enricocolasante
approved these changes
Jul 2, 2024
muilpp
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #17916
Big picture
Tracker has multiple services for each entity like tracked entity, enrollment and event. One is in dhis-api and one in dhis-service-tracker. Our goal is to provide one API (service) per entity that is part of the tracker domain/team.
Trackers architecture splits read/write into exporter services and an importer. So if you want to get data you use an exporter. If you want to insert, update or delete you have to go through the importer. Only then can we ensure integrity of tracker data.
Another goal is that code that provides tracker functionality and is thus owned by the tracker team lives in ideally one maven module (We can settle on a name later on maybe
dhis-service-trackerordhis-tracker).This is a big task that we are going to implement in many small steps.
This PR
EventService.addEventwas only used in the EventService itself (inlined) and tests.DhisConvenienceTestbase class already has acreateEventthat fulfilled most of what the tests relied on.Store the event via the
IdentifiableObjectManageras we do for many other testfixtures.