fix: Validate no datavalues for some event statuses [DHIS2-17658] #17934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teleivo
reviewed
Jul 1, 2024
.../main/java/org/hisp/dhis/tracker/imports/validation/validator/event/DataValuesValidator.java
Outdated
Show resolved
Hide resolved
dhis-2/dhis-api/src/main/java/org/hisp/dhis/tracker/imports/validation/ValidationCode.java
Outdated
Show resolved
Hide resolved
...t-e2e/src/test/java/org/hisp/dhis/tracker/imports/events/EventsDataValueValidationTests.java
Show resolved
Hide resolved
teleivo
approved these changes
Jul 2, 2024
dhis-2/dhis-api/src/main/java/org/hisp/dhis/tracker/imports/validation/ValidationCode.java
Outdated
Show resolved
Hide resolved
…lidation/ValidationCode.java Co-authored-by: teleivo <[email protected]>
|
muilpp
approved these changes
Jul 2, 2024
enricocolasante
added a commit
that referenced
this pull request
Jul 8, 2024
…7934) * fix: Validate no datavalues for some event statuses [DHIS2-17658] * Fix tests * Fix code review comments * Update dhis-2/dhis-api/src/main/java/org/hisp/dhis/tracker/imports/validation/ValidationCode.java Co-authored-by: teleivo <[email protected]> --------- Co-authored-by: teleivo <[email protected]>
enricocolasante
added a commit
that referenced
this pull request
Jul 8, 2024
….41) (#18015) * fix: Add event validation when updating status [DHIS2-17658] (#17890) * fix: Add event validation when updating status [DHIS2-17658] * Fix sonar issues * Fix code review comments * Fix code review comments * Fix code review comments * Fix code review comments * fix: Validate no datavalues for some event statuses [DHIS2-17658] (#17934) * fix: Validate no datavalues for some event statuses [DHIS2-17658] * Fix tests * Fix code review comments * Update dhis-2/dhis-api/src/main/java/org/hisp/dhis/tracker/imports/validation/ValidationCode.java Co-authored-by: teleivo <[email protected]> --------- Co-authored-by: teleivo <[email protected]> * fix: Skip mandatory data value validation for UPDATE [DHIS2-17560] (#17835) * fix: Skip mandatory data value validation for UPDATE [DHIS2-17560] * More clean up * Fix tests * Add tests * Add tests --------- Co-authored-by: teleivo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #17890.
Event statuses
OVERDUE,SKIPPEDandSCHEDULEdo not allow to define data values. This PR is adding a validation to verify this.