feat: Prevent duplicate event creation from SCHEDULEEVENT rule action [DHIS2-19849] #21433
Conversation
There was a problem hiding this comment.
We need to review the logic:
If the program stage is non-repeatable, the system will skip scheduling a new event if an existing one is already present for the same enrollment.
If the program stage is repeatable, the scheduling logic will proceed and allow the new event to be created.
I don't think this is enough to prevent duplicates. If the program stage is repeatable then every time there is a small change to the event (like change the value of a data value, update the status), a new event is scheduled. We need to prevent this kind of creation. The scheduled event should be created only once, no matter the type of the program stage
| @@ -106,8 +107,8 @@ public Map<ProgramRuleActionType, ProgramRuleActionValidator> programRuleActionV | |||
| ProgramRuleActionType.HIDEFIELD, | |||
| getProgramRuleActionValidatorByClass(BaseProgramRuleActionValidator.class)) | |||
| .put( | |||
| ProgramRuleActionType.CREATEEVENT, | |||
There was a problem hiding this comment.
Do we need to keep the base validator for CREATEEVENT?
| @@ -81,9 +81,10 @@ public void preheatAdd(TrackerObjects trackerObjects, TrackerPreheat preheat) { | |||
|
|
|||
| List<String> notRepeatableProgramStageUids = | |||
| trackerObjects.getEvents().stream() | |||
| .map(Event::getProgramStage) | |||
| .map(Event::getProgram) | |||
There was a problem hiding this comment.
Why do you need to change this code?
We are potentially introducing a lot of unnecessary data into the Preheat.
There was a problem hiding this comment.
Why is this change here? Do you need to rebase?
|
Just a thought, would be a good first version if we only allow one scheduled event to exist even if it is a repeatable program stage? So if there already is a scheduled event for that program stage, then no new scheduled event is created. @enricocolasante @zubaira thoughts? |
@ameenhere that's what we agreed upon. |
|
DO NOT MERGE. This PR should be merged after this one. #19868.
https://dhis2.atlassian.net/browse/DHIS2-19849
This PR continues the work from #19868. It introduces a validation step in the rule-engine–based scheduling logic to avoid creating duplicate events.
If the program stage is non-repeatable, the system will skip scheduling a new event if an existing one is already present for the same enrollment.
If the program stage is repeatable, the scheduling logic will proceed and allow the new event to be created.