Various UI fixes & Code cleanups #2703
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Character Editor had wrong BG color when no charater was selected. Adds Icons to the Create New Character/Timeline button (when those editors are empty), to make it clearer that the buttons in the toolbar do the same thing.
- makes sure sidebar tree margin is correct on load - makes key a variant, because it can be null
This was incorrect in the z-index field of the character event.
Import portraits from Folder now expects selecting a series of files instead of a folder, as it is more intuitve and flexible. Changes various icon button tooltips (E.g. New Timeline instead of Add Timeline) to be more in line with godot terminology
When having godot in a different language, random parts in dialogic where translated, resulting in a very bad look. For now auto-translation should be disabled on the whole interface.
The autoload was re-added every time the plugin loaded, because godot now saves autoloads by UID and thus "Core" was never in the return value of the setting. I think it's fine to drop this small auto-upgrade.
The lines on choices where broken when choices where directly inside of each other or at the end of a timeline.
Though on most events with a body it's useful to have them open when first created, on some it's kinda annoying imo. So for now the label, choice, wait input will stay collapsed when created. My reasoning is a bit different for them. For label and wait input I think you mostly don't need those settings. But for choices it's mostly because you will often add a bunch of choices at once and then having them all expanded is unnecessary.
This is functionality since 4.2, so it should be fine to switch to it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.