You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Guild.BannerURL() returns the banner as a PNG URL no matter the circumstances. I'm not sure if banners were PNG-only when they were first added to Discord, but they can be animated now and we can use the same logic to determine if it's animated or not as we do with user avatars and guild icons.
I'm not sure if banners were PNG-only when they were first added to Discord
I think they are. I'm not sure if I would agree with this change, since it is an unnecessary breaking change: clients that don't support GIFs will now unexpectedly get a GIF sometimes.
I'm not sure if banners were PNG-only when they were first added to Discord
I think they are. I'm not sure if I would agree with this change, since it is an unnecessary breaking change: clients that don't support GIFs will now unexpectedly get a GIF sometimes.
That's fair, I'd think they'd use Guild.BannerURLWithType() if they wanted to ensure it's a specific type but I suppose this has been documented to return PNG only. We could add another method then perhaps? BannerURLAuto() or something along those lines? Obviously ...WithType(AutoImage) could be used but the available methods could lead someone to believe GIF banners aren't supported.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
Guild.BannerURL()returns the banner as aPNGURL no matter the circumstances. I'm not sure if banners were PNG-only when they were first added to Discord, but they can be animated now and we can use the same logic to determine if it's animated or not as we do with user avatars and guild icons.