Separate Main Loop #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few small conflicts, could you please resolve them? |
kphoenix137
force-pushed
the
separate-main-loop
branch
from
06b2387
to
676d7b7
Compare
Should be all set. |
AJenbo
previously approved these changes
Oct 2, 2023
AJenbo
dismissed
their stale review
Doesn't post the game list after this change
|
Looks like this change causes it to get stuck here: I'll try to debug it a bit alter |
…evilutionx-gamelist into separate-main-loop
Comment on lines
+301
to
+302
| loop = asyncio.get_event_loop() | ||
| loop.create_task(background_task()) # Run background_task() as a separate task when the client is ready. |
There was a problem hiding this comment.
Is it necessary to call create_task() on the current event loop, or can we just call the higher-level asyncio.create_task() function? The asyncio documentation suggests that the event loop API calls are low-level functions that typically shouldn't need to be used by applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on: #18
Fixes: #17