Change Plain Text to Embed #20
Conversation
kphoenix137
commented
Oct 2, 2023
•
kphoenix137
commented
| diablo_retail_url = 'https://user-images.githubusercontent.com/68359262/272125642-d3363701-9b6e-4eff-b43e-11b9a0b58813.png' | ||
| diablo_shareware_url = 'https://user-images.githubusercontent.com/68359262/272125649-076eb58c-f587-4b16-822f-7d9b56559c69.png' | ||
| hellfire_retail_url = 'https://user-images.githubusercontent.com/68359262/272125658-3fc00693-e6dc-4273-81e8-803dbf9f5d93.png' | ||
| hellfire_shareware_url = 'https://user-images.githubusercontent.com/68359262/272125665-17805298-1400-49aa-a6a3-ac80ba5767ee.png' |
There was a problem hiding this comment.
I feel it would be better to upload the images to the repo and reference those URLs.
There was a problem hiding this comment.
Does AJenbo have to do that?
There was a problem hiding this comment.
You can add the files to your PR and preemptively determine what the URLs would be once merged. Or break it into two PRs so the graphics can be added first.
| 'LTHR': hellfire_retail_url, # Lord of Terror Hellfire Retail (kphoenix) | ||
| 'LTHS': hellfire_shareware_url, # Lord of Terror Hellfire Shareware (kphoenix) | ||
| } | ||
| embed["thumbnail"]["url"] = game_type_icons.get(game['type'], "") |
There was a problem hiding this comment.
Seems like the empty string would cause an exception. Since the thumbnail is optional, we should remove it completely if the URL would be invalid.
There was a problem hiding this comment.
I think we should use a placeholder graphic. Maybe the retail diablo icon, or something else as a placeholder for unknown game id
There was a problem hiding this comment.
If so, I would avoid using an icon we're already using. However, I would caution against making unknown game types recognizable. Players will use the icon to differentiate between game types, but unknown game types would all share the same icon. Maybe a question mark would be appropriate, but I think no icon is perfectly reasonable.
But honestly, for all we know, the unknown game type could be an attacker trying to confuse or crash the bot. The main thing is to avoid exceptions that would compromise the main loop.
There was a problem hiding this comment.
I'll come up with something good
| text += ' Hell' | ||
|
|
||
| embed = { | ||
| "type": "rich", |
There was a problem hiding this comment.
Let's change all double-quotes to single-quotes. It's more consistent with the rest of the file.
